Skip to content

Add do_intersect for convex hulls#6557

Open
sloriot wants to merge 113 commits intoCGAL:mainfrom
sloriot:CH3-do_intersect
Open

Add do_intersect for convex hulls#6557
sloriot wants to merge 113 commits intoCGAL:mainfrom
sloriot:CH3-do_intersect

Conversation

@sloriot
Copy link
Member

@sloriot sloriot commented May 4, 2022

Summary of Changes

Add convex hull do-intersect predicates based on this paper.

Release Management

  • Affected package(s): Convex_hull_3
  • Feature/Small Feature (if any): Convex_hull_intersection_test
  • Link to compiled documentation: link
  • License and copyright ownership: INRIA Nancy + GF

TODOs:

  • Small features
  • CGALize code
  • Import GJK for separation_distance()
  • Check the improved GJK, see here
    --> I don't see big differences with the original method, I don't think is relevant with exact computations.
  • Import dedicated code for OBBs
    --> Computing OBBs is significantly slower than computing convex hulls and their hierarchies, and applying transformations is difficult with exact computations. Therefore, using do_intersect() on the convex hulls or on the hierarchies is sufficiently fast in this context.
  • Update Installation/changes.md

@sloriot sloriot added Not yet approved The feature or pull-request has not yet been approved. Small feature TODO Pkg::Convex_hull_3 labels May 4, 2022
@MaelRL MaelRL added this to the 5.6-beta milestone May 5, 2022
@MaelRL MaelRL modified the milestones: 5.6-beta, 5.7-beta Mar 23, 2023
@janetournois janetournois modified the milestones: 6.0-beta, 6.1-beta May 16, 2024
@MaelRL MaelRL modified the milestones: 6.1-beta, 6.2-beta Mar 17, 2025
@MaelRL

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@MaelRL

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6557/v5/Manual/index.html

@sloriot
Copy link
Member Author

sloriot commented Feb 12, 2026

Successfully tested in CGAL-6.2-Ic-108

@MaelRL MaelRL added pre-approved For pre-approved small features. After 15 days the feature will be accepted. and removed Not yet approved The feature or pull-request has not yet been approved. labels Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Check size Pkg::Convex_hull_3 pre-approved For pre-approved small features. After 15 days the feature will be accepted. Small feature Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants